Andrei Gorbaichuk

Bug: Duplicate Media Attachments in Chat

Use  https://github.com/zendesk/zendesk_sdk_demo_apps_android  zendesk_sdk_demo as example

Current Zendesk version: 

implementation "zendesk.messaging:messaging-android:2.25.0", also reproducible in versions prior to 2.25.0.

Bug reproducible in Android versions 7-12 (API level 25-32) and NOT reproducible in Android 13 (API level 33) and above.

Steps (Minimal Scenario):

1. Set up credentials and open the sample app.
2. Press “Show conversation.”
3. Tap "Attach file" and choose “Upload a file.”
4. Tap the back button.
5. Tap "Attach file" again and choose “Take a photo.”
6. Confirm sending the file.

Actual Result: Multiple files are attached in the chat instead of one.

Expected Result: No duplicate files should appear in the chat.

Repeating steps 3 and 4 will increase the number of attachments.

The points  I want to discuss are related to the Android SDK initialization process.

initialize(Context  context, String  channelKey, SuccessCallback successCallback, FailureCallback failureCallback, MessagingFactory messagingFactory)

We have determined that the first init call must occur with an active internet connection, while subsequent calls succeed even without it. We want to ensure that the Zendesk instance is initialized. Should we check the connection status before calling init and do this only for the first launch? How can we determine when this check is necessary and when it is not?

In addition, in the failureCallback, we receive a Throwable, and if we want to track connection failures, we need to know all the types of exceptions that can occur during the initialization process in offline mode (for example, java.net.UnknownHostException, …).

I believe that the failureCallback should receive either your internal exception and/or an enum indicating a connection failure. This way, it would be easy for us to understand that the initialization issue is specifically related to being offline, and we can retry when we are back online.

Something like that:

public fun interface FailureCallback {
    public fun onFailure(code: ZendeskErrorCodes,  error: E)
}

Thank you in advance for your support and participation. I look forward to your insights on resolving this issue.