Recent searches


No recent searches

[Android] Old Dagger dependency prevents to remove Jetifier support



Posted Nov 16, 2021

Hello,

We are trying to remove Jetifier to increase build speed, but Zendesk still depends on old support libraries.

Zendesk SDK is using an old version of Dagger ("com.google.dagger:dagger-android:2.23.2") released on 19 Jun 2019 that uses support library "com.android.support:support-annotations:28.0.0".
Dagger was migrated to AndroidX on version 2.26, 30 Jan 2020. Zendesk SDK should be updated at least to that version.

We are using "com.zendesk:messaging:5.0.5" and "com.zendesk:support:5.0.5".

 

Regards,

Adrián.

 


4

15

15 comments

image avatar

Mick O'Donnell

Zendesk Product Manager

Hi Adrián,

Thank you for flagging this issue with us. We've prioritized work to get the external dependencies of this SDK updated as a high priority. I'll reply to this post with an update as soon as the release is ready.

Kind regards,

Mick

0


Mick O'Donnell do you have any updates or ETA on this?

Thank you.

2


Mick O'Donnell,
Following the release notes the migration to AndroidX should have been done in the version 5.0 https://developer.zendesk.com/documentation/classic-web-widget-sdks/support-sdk/android/release_notes/#500 5 months ago.
Is there any updates on this? This is blocking important build time improvement from our team.

3


Adding some additional detail

com.zendesk:support:5.0.6 -> com.zendesk.suas:suas:1.2.0 -> com.android.support:support-annotations:27.0.2

3


Any updates on this?

0


image avatar

Mick O'Donnell

Zendesk Product Manager

Hi all,

You should just need to update to the latest version (5.0.8) of the Support SDK. This version depends on Dagger 2.40. Please let us know if you've any further issues related to this. We'll try to be more explicit in the release notes.

-1


Mick O'Donnell
I updated but it is still depending on this library https://mvnrepository.com/artifact/com.zendesk.suas/suas/1.2.0

com.zendesk:support:5.0.8 -> com.zendesk.suas:suas:1.2.0 -> com.android.support:support-annotations:27.0.2

So it keeps warning about Jetifier

1


image avatar

Mick O'Donnell

Zendesk Product Manager

Hi Bruno,

Thank you for bringing this to our attention! We're going to investigate, and I'll update on this post as soon as we have a resolution to this issue.

1


To add some information on this, I am also currently on version 5.0.8 of the support SDK and the dependency is very much still there. Like the other posters here I hope this can be resolved soon. Maybe this summary from ByeByeJetifier can help you:

[...] Your project has set `android.useAndroidX=true`, but [...]

The following legacy support libraries are detected: -> com.zendesk:support:5.0.8 -> com.zendesk.suas:suas:1.2.0 -> com.android.support:support-annotations:27.0.2","sources":[{}]}

Scanning com.zendesk.suas:suas:1.2.0
 Absolute path: [...] com.zendesk.suas\suas\1.2.0\67ff6bbd96dc9c91c4e826e569fb92adc6af3cf\suas-1.2.0.jar
 Graphs to this dependency:
 +---com.zendesk:support:5.0.8
     +---com.zendesk.suas:suas:1.2.0
 Issues found:
 * pom -> com.android.support:support-annotations:27.0.2

1


Mick O'Donnell this should be a very easy fix that should take a couple of minutes and will help a lot of developers speed up their build process. It has been open for over 6 months without any progress. If you aren't able to fix it, could you provide some way for us to help you fix it? 

1


Yeah, agreed. For context, this would shave off 30 seconds of every single one of our builds... Considering how many builds we do a day, the time savings are really significant. This is the last library we use that's preventing us from turning off Jetifier and getting those time savings back.

0


image avatar

Mick O'Donnell

Zendesk Product Manager

Hi folks, sorry for the delay. We've actively working on this dependency update, but I don't have a public date that we can share at the moment. There's a chain of dependencies that needed to be addressed for this work. I will update Community as soon as we have a release.

1


image avatar

Mick O'Donnell

Zendesk Product Manager

Hey folks,

Just a quick update, we have now released a new version of the Support SDK and the Chat SDK to upgrade these dependencies. The release notes are here:

Refactor the internal Suas library to migrate to AndroidX.

Thank you for your patience on this one! Please let us know if you have any further issues around this subject, and thanks again for your feedback on Community!

0


This doesn't seem to be an issue anymore. Thank you for fixing it!

0


Agreed, everything looks good from our perspective now, too. Thanks Mick O'Donnell and team!

0


Please sign in to leave a comment.

Didn't find what you're looking for?

New post